Project

General

Profile

Refactor #12179

String extraction in host_inherited_params is wrong

Added by Ori Rabin almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

For managed hosts in host_inherited_params n_() is used to try and extract a string that isn't listed explicitly:
https://github.com/theforeman/foreman/blob/c1755e07/app/models/host/managed.rb#L453

This should be fixed to correctly extract all options for source.


Related issues

Related to Foreman - Bug #11763: Host API does not return all parameters (e.g. from locations, et al.)Closed2015-09-10

Associated revisions

Revision db516502 (diff)
Added by Ori Rabin over 3 years ago

Fixes #12179 - extracting strings in host_inherited_params correctly

Revision 18c4b17f (diff)
Added by Ori Rabin over 3 years ago

refs #12179 - refactoring extracted strings for host parameters

History

#1 Updated by Dominic Cleal almost 4 years ago

  • Related to Bug #11763: Host API does not return all parameters (e.g. from locations, et al.) added

#2 Updated by Dominic Cleal almost 4 years ago

  • Description updated (diff)
  • Legacy Backlogs Release (now unused) set to 63

Setting for 1.10.0, as it's a regression.

#3 Updated by Ori Rabin over 3 years ago

  • Status changed from New to Assigned

#4 Updated by The Foreman Bot over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee set to Ori Rabin
  • Pull request https://github.com/theforeman/foreman/pull/2946 added

#5 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) changed from 63 to 104

#6 Updated by Ori Rabin over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by The Foreman Bot over 3 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2948 added

#8 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) changed from 104 to 71

Refactoring in patch is too risky, moving.

Also available in: Atom PDF