Project

General

Profile

Refactor #12180

Move lookup_value presence validation to PuppetclassLookupKey

Added by Amir Fefer almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Smart Variables
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey.
This validation should be moved to the child class - PuppetClassLookupKey.

Associated revisions

Revision d4b8428f (diff)
Added by Amir Fefer over 3 years ago

Fixes #12180 - lookup_value presence validation moved from lookup_key

Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey.
This validation should affect on the child class - PuppetClassLookupKey.

History

#1 Updated by Amir Fefer almost 4 years ago

  • Subject changed from Move lookup_value presence validation to PuppetclassLookupValue to Move lookup_value presence validation to PuppetclassLookupKey

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2909 added

#3 Updated by Amir Fefer over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 71

Also available in: Atom PDF