Refactor #12180
Move lookup_value presence validation to PuppetclassLookupKey
Description
Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey.
This validation should be moved to the child class - PuppetClassLookupKey.
Associated revisions
History
#1
Updated by Amir Fefer about 4 years ago
Updated by - Subject changed from Move lookup_value presence validation to PuppetclassLookupValue to Move lookup_value presence validation to PuppetclassLookupKey
#2
Updated by The Foreman Bot about 4 years ago
Updated by - Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2909 added
#3
Updated by Amir Fefer almost 4 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset d4b8428f7c6116c209c3706c54be3915023e7159.
#4
Updated by Dominic Cleal almost 4 years ago
Updated by - Legacy Backlogs Release (now unused) set to 71
Fixes #12180 - lookup_value presence validation moved from lookup_key
Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey.
This validation should affect on the child class - PuppetClassLookupKey.