Actions
Refactor #12180
closed
Move lookup_value presence validation to PuppetclassLookupKey
Description
Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey.
This validation should be moved to the child class - PuppetClassLookupKey.
Updated by Amir Fefer over 8 years ago
- Subject changed from Move lookup_value presence validation to PuppetclassLookupValue to Move lookup_value presence validation to PuppetclassLookupKey
Updated by The Foreman Bot over 8 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2909 added
Updated by Amir Fefer over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset d4b8428f7c6116c209c3706c54be3915023e7159.
Updated by Dominic Cleal over 8 years ago
- translation missing: en.field_release set to 71
Actions