Project

General

Profile

Actions
Copy link

Bug #12225

closed

TopbarSweeper should invalidate on plugin installation/removal

Added by Lukas Zapletal over 10 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Plugin integration
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2849, https://github.com/theforeman/foreman/pull/3496, https://github.com/theforeman/foreman/pull/3517
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Users (and devs apparently) forget to log-out missing items in the main menu :)

Related issues 3 (1 open — 2 closed)

Related to Website - Feature #14670: Inform somewhere that after adding plugin user should logout/login to see it in WebUINew04/15/2016Actions
Related to Foreman - Bug #15040: Could not find table 'users' during db:migrateClosedDominic Cleal05/13/2016Actions
Related to Foreman - Bug #10802: relation "users" does not exist present when migratingClosedEric Helms06/12/2015Actions
Actions
Copy link
 #1

Updated by The Foreman Bot over 10 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2849 added
  • Pull request deleted ()
Actions
Copy link
 #2

Updated by Dominic Cleal almost 10 years ago

  • Related to Feature #14670: Inform somewhere that after adding plugin user should logout/login to see it in WebUI added
Actions
Copy link
 #3

Updated by Dominic Cleal almost 10 years ago

  • Category changed from Web Interface to Plugin integration
  • Status changed from Ready For Testing to New
  • Assignee deleted (Lukas Zapletal)

PR closed.

Actions
Copy link
 #4

Updated by Lukas Zapletal almost 10 years ago

  • Status changed from New to Rejected

Since we upgraded to Rails 4.x this patch is no longer necessary and it just works. Compare

http://edgeguides.rubyonrails.org/caching_with_rails.html#fragment-caching

with

http://guides.rubyonrails.org/v3.2/caching_with_rails.html#fragment-caching

(search for md5)

Actions
Copy link
 #5

Updated by Dominic Cleal almost 10 years ago

  • Status changed from Rejected to New

Re-opening as the issue is still present, tested on current develop. As per my comment at https://github.com/theforeman/foreman/pull/2849#issuecomment-217127785, the view fragment isn't changed when installing/uninstalling plugins, so the cache wouldn't get invalidated by the new mechanism in Rails 4. The digest is disabled in any case.

Actions
Copy link
 #6

Updated by The Foreman Bot almost 10 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/3496 added
Actions
Copy link
 #7

Updated by The Foreman Bot almost 10 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3517 added
Actions
Copy link
 #8

Updated by Lukas Zapletal almost 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Dominic Cleal almost 10 years ago

  • Related to Bug #15040: Could not find table 'users' during db:migrate added
Actions
Copy link
 #10

Updated by Dominic Cleal almost 10 years ago

  • Translation missing: en.field_release set to 136
Actions
Copy link
 #11

Updated by Dominic Cleal almost 10 years ago

  • Related to Bug #10802: relation "users" does not exist present when migrating added
Actions
Copy link

Also available in: Atom PDF