Bug #12225: TopbarSweeper should invalidate on plugin installation/removal - Foreman

Custom queries

3.11.5 release DONE
3.11.5 release TODO
3.12.2 release DONE
3.12.2 release TODO
3.13.0 release DONE
3.13.0 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #12225

closed

TopbarSweeper should invalidate on plugin installation/removal

Added by Lukas Zapletal about 9 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

Plugin integration

Target version:

1.12.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2849, https://github.com/theforeman/foreman/pull/3496, https://github.com/theforeman/foreman/pull/3517

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Users (and devs apparently) forget to log-out missing items in the main menu :)

Related issues 3 (1 open — 2 closed)

Related to Website - Feature #14670: Inform somewhere that after adding plugin user should logout/login to see it in WebUI	New		04/15/2016	Actions
Related to Foreman - Bug #15040: Could not find table 'users' during db:migrate	Closed	Dominic Cleal	05/13/2016	Actions
Related to Foreman - Bug #10802: relation "users" does not exist present when migrating	Closed	Eric Helms	06/12/2015	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by The Foreman Bot about 9 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/2849 added
Pull request deleted ()

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Related to Feature #14670: Inform somewhere that after adding plugin user should logout/login to see it in WebUI added

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Category changed from Web Interface to Plugin integration
Status changed from Ready For Testing to New
Assignee deleted (~~Lukas Zapletal~~)

PR closed.

Actions

Copy link

Updated by Lukas Zapletal over 8 years ago

Status changed from New to Rejected

Since we upgraded to Rails 4.x this patch is no longer necessary and it just works. Compare

http://edgeguides.rubyonrails.org/caching_with_rails.html#fragment-caching

with

http://guides.rubyonrails.org/v3.2/caching_with_rails.html#fragment-caching

(search for md5)

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Status changed from Rejected to New

Re-opening as the issue is still present, tested on current develop. As per my comment at https://github.com/theforeman/foreman/pull/2849#issuecomment-217127785, the view fragment isn't changed when installing/uninstalling plugins, so the cache wouldn't get invalidated by the new mechanism in Rails 4. The digest is disabled in any case.

Actions

Copy link