Project

General

Profile

Bug #12245

Nic::Bootable should be removed

Added by Dominic Cleal about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Network
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The Nic::Bootable model should have been removed entirely in #10988, but instead only the deprecation warning (when using the class) was removed. The model should be deleted.


Related issues

Related to Foreman - Refactor #10988: Remove 1.11 deprecationsClosed2015-07-02
Related to Foreman - Bug #10020: Smart Proxy DHCP does not set option 66 and 67 (nextServer, filename) on new DHCP Record creationClosed2015-04-03

Associated revisions

Revision 93d1e467 (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #12245 - Remove Nic::Bootable

Problem
On c1755e070ee10ee026e0b3996378368369c4ca83 I removed the deprecation of
using Nic::Bootable. However the model could still be used, now without
any warning.

Solution
Remove the model and other instances where it's called, and substitute
it by Nic::Managed with provision set to true.

History

#1 Updated by Dominic Cleal about 4 years ago

#2 Updated by Dominic Cleal about 4 years ago

  • Related to Bug #10020: Smart Proxy DHCP does not set option 66 and 67 (nextServer, filename) on new DHCP Record creation added

#3 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2855 added
  • Pull request deleted ()

#4 Updated by The Foreman Bot about 4 years ago

  • Assignee set to Daniel Lobato Garcia

#5 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF