Project

General

Profile

Bug #12256

Rollback during discovered host provisioning errors with ERF42-8175 and causes post_commit orchestration

Added by Lukas Zapletal almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Discovery plugin
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We should provide an empty method there.

2015-10-22 04:45:49 [app] [W] Failed to perform rollback on Rebooting discovered-host-1.discovery.test - ERF42-8175 [Foreman::Exception]: invalid method delReboot
 | Foreman::Exception: ERF42-8175 [Foreman::Exception]: invalid method delReboot
 | /usr/share/foreman/app/models/concerns/orchestration.rb:165:in `execute'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:131:in `block in process'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:127:in `reverse_each'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:127:in `process'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:39:in `post_commit'

Related issues

Related to Foreman - Bug #14001: Wrapping `host.save` call into external trasnaction causes the `post_commit` orchestration to be triggered even when failures in `pre_commit` orchestrationNew2016-03-02
Related to Foreman - Tracker #14002: Orchestration build around ActiveRecord hooks trackerNew2016-03-02

Related to Discovery - Bug #9306: User without hostgroup view permissions can't create discover rulesClosed2015-02-10

Associated revisions

Revision df4df986 (diff)
Added by Lukas Zapletal over 3 years ago

Fixes #12256 - removed explicit transactions

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/225 added
  • Pull request deleted ()

#2 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Ivan Necas over 3 years ago

  • Related to Bug #14001: Wrapping `host.save` call into external trasnaction causes the `post_commit` orchestration to be triggered even when failures in `pre_commit` orchestration added

#4 Updated by Ivan Necas over 3 years ago

  • Related to Tracker #14002: Orchestration build around ActiveRecord hooks tracker added

#5 Updated by Lukas Zapletal over 3 years ago

  • Subject changed from Rollback during discovered host provisioning errors with ERF42-8175 invalid method delReboot to Rollback during discovered host provisioning errors with ERF42-8175 and causes post_commit orchestration
  • Bugzilla link set to 1347992

Updated the subject, this bug seems to be more important that it looks like at first sight (see Ivans comment).

#6 Updated by Lukas Zapletal about 3 years ago

  • Related to Bug #9306: User without hostgroup view permissions can't create discover rules added

Also available in: Atom PDF