Project

General

Profile

Bug #12271

Audit of template change has an empty diff

Added by Thomas McKay almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

All job template audit diffs are blank in UI.

diff.png View diff.png 20.9 KB Marek Hulán, 10/23/2015 10:26 AM
Diff

Related issues

Related to Foreman - Refactor #11625: Make foreman ace editor reusableClosed2015-08-31

Associated revisions

Revision f3756869 (diff)
Added by Dominic Cleal over 3 years ago

fixes #12271 - update ace editor usage, remove unused JS

Revision 96f624f8 (diff)
Added by Dominic Cleal over 3 years ago

fixes #12271 - update ace editor usage, remove unused JS

(cherry picked from commit f375686909929748590f94fbce08b49cda2cc636)

History

#1 Updated by Marek Hulán almost 4 years ago

Is this what you mean?

#2 Updated by Marek Hulán almost 4 years ago

  • Project changed from Foreman Remote Execution to Foreman
  • Subject changed from audit of job template change has an empty diff to Audit of template change has an empty diff
  • Category set to Templates

This is present in core for other templates types as well, probably not remote execution related. Moving to core.

#3 Updated by Dominic Cleal almost 4 years ago

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

#5 Updated by Dominic Cleal almost 4 years ago

The JavaScript include needs updating from provisioning_template to editor, and the page may need updating to work with the refator in fa8353d.

#6 Updated by Thomas McKay almost 4 years ago

To reproduce: Edit any provisioning template text and save, then visit the History tab and click the "Show Diff" link. Note that the diff is empty.

#7 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) changed from 63 to 104

#8 Updated by Dominic Cleal over 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal

#9 Updated by The Foreman Bot over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3065 added

#10 Updated by Dominic Cleal over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#11 Updated by Marek Hulán over 3 years ago

  • Bugzilla link set to 1274045

Also available in: Atom PDF