Project

General

Profile

Refactor #12311

Refactor rack openid middleware initialization to be both rails3 & 4 compatible

Added by Chris Peters about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When placed in a rails initializer the rack middleware fails to load, throwing a can't modify frozen array error. Moving the initialization to the application config resolves this issue.

Associated revisions

Revision 212b8250 (diff)
Added by Chris Peters about 4 years ago

Fixes #12311 - Fix issue with failed initialization of rack openid middleware.

This fix is for rails4 but is backwards compatible with rails3

When placed in a rails initializer the rack middleware fails to
load, throwing a can't modify frozen array error. Moving the
initialization to the application config resolves this issue.

History

#2 Updated by Daniel Lobato Garcia about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2854 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal about 4 years ago

  • Category set to Rails
  • Status changed from New to Ready For Testing
  • Legacy Backlogs Release (now unused) set to 71

#4 Updated by Chris Peters about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF