Project

General

Profile

Bug #12425

Fact import triggers ip conflicts checks, which drives cpu utilization to 100% on smart-proxy

Added by Dmitri Dolguikh about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

This is an expensive call, and performing lots of them has a serious impact on smart-proxy. See http://projects.theforeman.org/issues/12392 for more details and discussion.


Related issues

Related to Smart Proxy - Bug #12392: 100% cpu usage on foreman-proxy DHCP callsResolved2015-11-04
Related to Foreman - Bug #13725: Orchestration fails with 409 when there is a MAC DHCP conflictClosed2016-02-16

Associated revisions

Revision 5351c86f (diff)
Added by Timo Goebel over 3 years ago

fixes #12425 - do not trigger orchestration during fact import

History

#1 Updated by Dmitri Dolguikh about 4 years ago

  • Related to Bug #12392: 100% cpu usage on foreman-proxy DHCP calls added

#2 Updated by Dmitri Dolguikh about 4 years ago

  • Category set to Orchestration

#3 Updated by Dominic Cleal about 4 years ago

From #12392, Dmitri says:

It might be possible to set some flag indicating that fact import is in progress, but it's going to be messy.

When saving hosts during fact/report importing we use .save(:validate => false) - not really in an attempt to disable validation, but to disable orchestration (as I understand it). The same isn't done for saving network interfaces, and now that orchestration's in those models, it's running.

If we had a flag to disable orchestration generally instead of disabling validation, we might be able to keep validation on NICs (something we really shouldn't go backwards on by disabling) while disabling orchestration changes at a high level?

#4 Updated by Toni Schmidbauer over 3 years ago

setting ignore_puppet_facts_for_provisioning to true resolved this issue for us.

#5 Updated by Timo Goebel over 3 years ago

https://github.com/theforeman/foreman/commit/4c9529c7bc3c081fb3d0bfdbee09b2e7d6eabc0a#diff-5e596b03372d6df756203e6c69444742

Makes this worse as Foreman now does two calls to smart-proxy during fact import effectively doubling the load.

#6 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Timo Goebel
  • Pull request https://github.com/theforeman/foreman/pull/3471 added

#7 Updated by Dmitri Dolguikh over 3 years ago

If you are using ISC dhcpd, I would suggest testing import against changes in https://github.com/theforeman/smart-proxy/pull/409, calls to smart-proxy's dhcp module (when used with ISC dhcpd) no longer incur heavy penalty.

#8 Updated by Dominic Cleal over 3 years ago

  • Related to Bug #13725: Orchestration fails with 409 when there is a MAC DHCP conflict added

#9 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#10 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 136

#11 Updated by Brad Buckingham over 3 years ago

  • Bugzilla link set to 1341860

Also available in: Atom PDF