Project

General

Profile

Bug #12469

ISC DHCP proxy errors when attempting to delete nonexistant records

Added by Brandon Weeks almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
DHCP
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

When trying to delete an nonexistent host via omshell the ISC DHCP proxy an exception is raised and an error returned to Foreman. This causes issues with Host::Managed.populate_fields_from_facts.

omshell_traceback.txt omshell_traceback.txt 4.54 KB Brandon Weeks, 11/13/2015 06:29 AM

Related issues

Related to Smart Proxy - Bug #12465: ISC DHCP proxy fails to parse deleted entiresClosed2015-11-13

Associated revisions

Revision f24be74d (diff)
Added by Brandon Weeks almost 4 years ago

Fixes #12469 - raise Proxy::DHCP::InvalidRecord

Raise Proxy::DHCP::InvalidRecord if delRecord is called on a nonexistant record by looking for the `omshell` error.

History

#1 Updated by Dominic Cleal almost 4 years ago

Note that Foreman deliberately ignores a 404 HTTP response from the smart proxy during DHCP record deletion, expecting a 404 to be given if there's no such record to delete. I've not checked yet whether this has changed in the proxy between versions.

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/339 added

#3 Updated by Dominic Cleal almost 4 years ago

  • Related to Bug #12465: ISC DHCP proxy fails to parse deleted entires added

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) deleted (63)

Removing from the 1.10.0 blockers as it seems to stem entirely from the linked bug, where a deleted entry is still being picked up and so dhcp_api doesn't return with a 404 early.

#5 Updated by Dominic Cleal almost 4 years ago

  • Assignee set to Brandon Weeks
  • Legacy Backlogs Release (now unused) set to 104

Leaving on .1 so we've got more time to soak test this change. The regression (#12465) needs to go in sooner as it'll fix more than this will.

#6 Updated by Brandon Weeks almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF