Project

General

Profile

Bug #12512

net-ssh/scp dependencies are missing when Fog group not installed

Added by Dominic Cleal almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

With Fog 1.36.0, the net-ssh and net-scp dependencies are no longer on the fog-core gem and are instead in our 'fog' bundler group.

Since #10787 plus #8516, it's been possible to install just foreman-gce, foreman-libvirt or the gce/libvirt bundler groups without foreman-compute/the fog bundler group (which brings in 'fog' itself) installed.

If you install one of these bundler groups now without the fog group or foreman-compute, you won't have net-ssh or net-scp installed since there's no gem dependency to bring them in. This will cause a runtime error in fog-core.


Related issues

Related to Foreman - Refactor #12494: Update fog to 1.36.0Closed2015-11-16

Associated revisions

Revision 4a8834e4 (diff)
Added by Dominic Cleal almost 4 years ago

fixes #12512 - always install fog-core/net-* dependencies

fog-core 1.33 made net-* deps optional, but Foreman relies on them for
image provisioning on many CR types. Since the 'fog' Bundler group is
optional (e.g. the 'ec2' group can be used standalone as fog-aws depends
on fog-core), these deps have been moved into the main Gemfile so they
are always available for any CR when the 'fog' group isn't installed.
fog-core was also moved to ensure it's always pinned appropriately.

Although the gems aren't always required, this will make using the CR
Bundler groups less complex than adding another group specifically for
fog-core and net-* for Bundler users, in packages and in plugins.

Revision 970fc2d4 (diff)
Added by Dominic Cleal almost 4 years ago

refs #12494, #12512 - use fog 1.36, fog-core 1.34

Revision 9d14b631 (diff)
Added by Dominic Cleal over 3 years ago

refs #12512 - permit net-ssh 3.x on Ruby 2+

History

#1 Updated by Dominic Cleal almost 4 years ago

#2 Updated by Dominic Cleal almost 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal

I think we probably need to separate the fog-core (including net-*) bits out of the fog bundler group into a shared group or even into Foreman's general Gemfile. Having them in the fog group is misleading when it's optional.

#3 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2920 added

#4 Updated by Dominic Cleal almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF