Project

General

Profile

Bug #12517

VMWare VM should be created network based if it is selected in the gui

Added by Timo Goebel over 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - VMware
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When creating a host network based foreman creates the host image based because the image_id is always set.

in app/models/compute_resources/foreman/model/vmware.rb create_vm

if args[:image_id].present?
should be
if args[:provision_method] == 'image'


Related issues

Related to Foreman - Bug #10237: Host.new and API disregard provision_methodDuplicate2015-04-22
Related to Foreman - Bug #13986: Provisioning via API without explicitly specifying the provisioning method can lead to using combination of image and build provisioning methodsClosed2016-03-01
Has duplicate Foreman - Bug #13141: Cloning host discards provisioning methodDuplicate2016-01-12

Associated revisions

Revision 2328beb5 (diff)
Added by Timo Goebel over 4 years ago

fixes #12517 - VMWare VM should be created network based only if it is selected in the gui

Revision 9dd66bf7 (diff)
Added by Timo Goebel over 4 years ago

fixes #12517 - VMWare VM should be created network based only if it is selected in the gui

(cherry picked from commit 2328beb569d3f0e51043202d3a00a3b30879d244)

History

#1 Updated by Dominic Cleal over 4 years ago

I think the image_id in the New Host form is disabled for a network build so shouldn't be sent in the form parameters. This might happen if the image_id is stored on a compute profile as it'll get copied in regardless. #10237 reports this too from inside a plugin or the API.

#2 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #10237: Host.new and API disregard provision_method added

#3 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2921 added

#4 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 104

#5 Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal over 4 years ago

  • Has duplicate Bug #13141: Cloning host discards provisioning method added

#7 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #13986: Provisioning via API without explicitly specifying the provisioning method can lead to using combination of image and build provisioning methods added

Also available in: Atom PDF