Project

General

Profile

Refactor #12529

Use load_template_vars in TFTP orchestration's PXE menu generation

Added by Dominic Cleal about 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Templates
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

The generate_pxe_template in app/models/concerns/orchestration/tftp.rb manually sets initrd and kernel variables, but should use a shared helper for consistency with other template preview mechanisms.

This would avoid duplicating how those variables are set up, plus ensure that all other known instance variables are populated.

Changing it to use host.render_template might be best, or at least call load_template_vars.


Related issues

Related to Foreman - Feature #11643: Allow through API methods to render templates without configuring a host in build modeClosed2015-09-01

History

#1 Updated by Dominic Cleal about 4 years ago

  • Related to Feature #11643: Allow through API methods to render templates without configuring a host in build mode added

Also available in: Atom PDF