Project

General

Profile

Actions

Bug #12597

closed

Smart Proxy DNS tests have an extra method definition that is upsetting rubocop

Added by Aaron Stone over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The Smart Proxy Rubocop Jenkins is failing because of this test, which has an inexplicable nested definition:

```
+ def test_delete_returns_error_if_value_is_missing
+ def test_create_returns_error_if_type_is_missing
+ delete '/'
+ assert_equal 400, last_response.status
+ end
+ end
```

Relates to #12209


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Feature #12209: Introduce support for dependency injection in dns moduleClosed10/19/2015Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Aaron Stone
  • Pull request https://github.com/theforeman/smart-proxy/pull/350 added
Actions #2

Updated by Dominic Cleal over 8 years ago

  • Project changed from Foreman to Smart Proxy
  • Category set to Tests
Actions #3

Updated by Dominic Cleal over 8 years ago

  • Related to Feature #12209: Introduce support for dependency injection in dns module added
Actions #4

Updated by Aaron Stone over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 71
Actions

Also available in: Atom PDF