Project

General

Profile

Bug #12597

Smart Proxy DNS tests have an extra method definition that is upsetting rubocop

Added by Aaron Stone about 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The Smart Proxy Rubocop Jenkins is failing because of this test, which has an inexplicable nested definition:

```
+ def test_delete_returns_error_if_value_is_missing
+ def test_create_returns_error_if_type_is_missing
+ delete '/'
+ assert_equal 400, last_response.status
+ end
+ end
```

Relates to #12209


Related issues

Related to Smart Proxy - Feature #12209: Introduce support for dependency injection in dns moduleClosed2015-10-19

Associated revisions

Revision bef9bee9 (diff)
Added by Aaron Stone about 5 years ago

Fixes #12597: remove extraneous method definition in the DNS API tests

And removed redundant validation in dns api 'delete' call

History

#1 Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Aaron Stone
  • Pull request https://github.com/theforeman/smart-proxy/pull/350 added

#2 Updated by Dominic Cleal about 5 years ago

  • Project changed from Foreman to Smart Proxy
  • Category set to Tests

#3 Updated by Dominic Cleal about 5 years ago

  • Related to Feature #12209: Introduce support for dependency injection in dns module added

#4 Updated by Aaron Stone about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal about 5 years ago

  • Legacy Backlogs Release (now unused) set to 71

Also available in: Atom PDF