Bug #12618: Compute profile overrides compute attributes provided in host form - Foreman

Actions

Copy link

Bug #12618

closed

Compute profile overrides compute attributes provided in host form

Added by Marek Hulán about 9 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Category:

Compute resources

Target version:

1.10.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2937, https://github.com/theforeman/foreman/pull/2957

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

If I select compute profile and in Virtual Machine tab I change some compute attr (e.g. image to be used or amount of RAM) it gets overiden by what's set in compute profile when I submit.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by The Foreman Bot about 9 years ago

Status changed from Assigned to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/2937 added

Actions

Copy link

Updated by Dominic Cleal about 9 years ago

Related to Bug #12461: Compute profiles are not applied when inherited added

Actions

Copy link

Updated by Dominic Cleal about 9 years ago

Translation missing: en.field_release set to 63

This looks like a regression introduced by #12461, which calls set_compute_attributes from set_hostgroup_defaults without checking the value of compute_attributes.

Actions

Copy link

Updated by Marek Hulán about 9 years ago

I think that call is required, after you select a hostgroup you need to refresh compute attributes from profile unconditionally. Maybe now we can even remove the condition from before_validation if it makes more sense. Anyway thanks for quick look.

Actions

Copy link