Project

General

Profile

Bug #12676

Filter.rb contains two attr_accessible declarations

Added by Daniel Lobato Garcia about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Rails
Target version:
1.11.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2954
Fixed in Releases:
Found in Releases:

Description

The 2nd one should not be there, and the 1st one should include unlimited. See https://github.com/theforeman/foreman/blob/develop/app/models/filter.rb

Related issues

Related to Foreman - Bug #7568: Use attr_accessible for rails 4 upgradeClosed2014-09-22

Associated revisions

Revision 0dbd3e78 (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #12676 - Filter contains two attr_accessible declarations

The 2nd one was just the leftovers of the old declaration.
Organization/location attr_accessible are loaded via Taxonomies, and
:unlimited was missing from the first declaration so I moved it there.

History

#1 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2954 added

#2 Updated by Dominic Cleal almost 4 years ago

  • Related to Bug #7568: Use attr_accessible for rails 4 upgrade added

#3 Updated by Dominic Cleal almost 4 years ago

  • Category set to Rails
  • Legacy Backlogs Release (now unused) set to 71

#4 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF