Actions
Refactor #12822
open
Separate LookupValue to different classes per LookupKey type
Status:
New
Priority:
Normal
Assignee:
-
Category:
Parameters
Target version:
-
Description
As suggested by: https://github.com/theforeman/foreman/pull/2909#discussion_r46676200
LookupKey has been separated into two classes and LookupValue still has specific logic for each one.
LookupValue should also be separated or at least move the puppet specific logic into a child class.
Updated by Dominic Cleal about 9 years ago
- Related to Refactor #10832: Make LookupKey an STI for puppet and variable keys added
Updated by Ori Rabin about 9 years ago
- Status changed from New to Assigned
- Assignee set to Amir Fefer
Updated by Dominic Cleal almost 9 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3080 added
Updated by Dominic Cleal over 8 years ago
- Has duplicate Refactor #15710: Create STI for LookupValues added
Updated by Ori Rabin over 8 years ago
- Related to Refactor #15828: Turn default value in lookup key to a lookup value added
Updated by
Updated by Shimon Shtein over 8 years ago
At least from Puppet separation point of view, we can handle the LookupValue without inheritance.
All we need to do, is rename use_puppet_default to something more generic.
I have already opened an issue for that: [[http://projects.theforeman.org/issues/15846]]
Updated by Shimon Shtein over 8 years ago
- Related to Refactor #15846: Rename use_puppet_default in lookup values to skip_foreman added
Updated by Dominic Cleal over 8 years ago
- Status changed from Ready For Testing to New
- Assignee deleted (
Amir Fefer) - Pull request deleted (
https://github.com/theforeman/foreman/pull/3080)
No activity on PR after being put up for review.
Actions