Project

General

Profile

Refactor #12822

Separate LookupValue to different classes per LookupKey type

Added by Ori Rabin over 6 years ago. Updated almost 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Parameters
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

As suggested by: https://github.com/theforeman/foreman/pull/2909#discussion_r46676200
LookupKey has been separated into two classes and LookupValue still has specific logic for each one.
LookupValue should also be separated or at least move the puppet specific logic into a child class.


Related issues

Related to Foreman - Refactor #10832: Make LookupKey an STI for puppet and variable keysClosed2015-06-16
Related to Foreman - Refactor #15828: Turn default value in lookup key to a lookup valueNew
Related to Foreman - Refactor #15846: Rename use_puppet_default in lookup values to skip_foremanClosed2016-07-27
Has duplicate Foreman - Refactor #15710: Create STI for LookupValuesDuplicate2016-07-17

History

#1 Updated by Dominic Cleal over 6 years ago

  • Related to Refactor #10832: Make LookupKey an STI for puppet and variable keys added

#2 Updated by Ori Rabin over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Amir Fefer

#3 Updated by Dominic Cleal over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3080 added

#4 Updated by Dominic Cleal almost 6 years ago

#5 Updated by Ori Rabin almost 6 years ago

  • Related to Refactor #15828: Turn default value in lookup key to a lookup value added

#6 Updated by Ivan Necas almost 6 years ago

  • Target version set to 113

#7 Updated by Ivan Necas almost 6 years ago

  • Target version deleted (113)

#8 Updated by Shimon Shtein almost 6 years ago

At least from Puppet separation point of view, we can handle the LookupValue without inheritance.
All we need to do, is rename use_puppet_default to something more generic.
I have already opened an issue for that: [[http://projects.theforeman.org/issues/15846]]

#9 Updated by Shimon Shtein almost 6 years ago

  • Related to Refactor #15846: Rename use_puppet_default in lookup values to skip_foreman added

#10 Updated by Dominic Cleal almost 6 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Amir Fefer)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3080)

No activity on PR after being put up for review.

Also available in: Atom PDF