Project

General

Profile

Bug #12835

Tests failing after upgrade to foreman-tasks-0.7.8

Added by Ivan Necas over 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Due to rails 4 compatibily, find_by_exeternal_id was repaced with other construct in foreman-tasks, causing the tests
to miss the stubbing:

ActiveRecord::RecordNotFound (ActiveRecord::RecordNotFound)
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/activerecord-3.2.21/lib/active_record/relation/finder_methods.rb:129:in `first!'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/base.rb:5:in `task'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/recurring_logic.rb:38:in `task'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/recurring_logic.rb:26:in `block in plan'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/recurring_logic.rb:25:in `tap'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/recurring_logic.rb:25:in `plan'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/dynflow-0.8.9/lib/dynflow/middleware/stack.rb:22:in `call'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/dynflow-0.8.9/lib/dynflow/middleware/stack.rb:26:in `pass'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/dynflow-0.8.9/lib/dynflow/middleware.rb:17:in `pass'
/var/lib/workspace/workspace/test_plugin_matrix@2/database/postgresql/ruby/1.9.3/slave/fast/plugin/app/lib/actions/middleware/bind_job_invocation.rb:17:in `plan'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/dynflow-0.8.9/lib/dynflow/middleware/stack.rb:22:in `call'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/dynflow-0.8.9/lib/dynflow/middleware/stack.rb:26:in `pass'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/dynflow-0.8.9/lib/dynflow/middleware.rb:17:in `pass'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/keep_current_user.rb:25:in `block in plan'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/keep_current_user.rb:41:in `with_current_user'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_plugin_matrix-2/gems/foreman-tasks-0.7.8/app/lib/actions/middleware/keep_current_user.rb:24:in `plan'

Associated revisions

Revision 188edf19 (diff)
Added by Ivan Necas over 6 years ago

Fixes #12835 - fix stubbing in tests after upgrade to foreman-tasks-0.7.8

Revision 4588048c
Added by Marek Hulán over 6 years ago

Merge pull request #86 from iNecas/fix-tests

Fixes #12835 - fix stubbing in tests after upgrade to foreman-tasks-0.7.8

History

#1 Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Target version set to 92
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/86 added

#2 Updated by Marek Hulán over 6 years ago

  • Legacy Backlogs Release (now unused) set to 108

#3 Updated by Ivan Necas over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF