Project

General

Profile

Actions
Copy link

Bug #12925

open

Need to break up Repository model to smaller size

Added by Partha Aji over 9 years ago. Updated 8 months ago.

Status:
Ready For Testing
Priority:
Normal
Assignee:
Partha Aji
Category:
-
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/5685
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Repository model is close to breaking the max class length rubo cop limit.

According to our rubocop metrics, max length per class is 500 lines. Repository.rb is very close to crossing that.
https://github.com/Katello/katello/blob/master/app/models/katello/repository.rb

One approach is to split functionality to different modules and include it in the main model.

Actions
Copy link
 #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5685 added
Actions
Copy link
 #2

Updated by Eric Helms over 9 years ago

  • Translation missing: en.field_release set to 114
Actions
Copy link
 #3

Updated by Partha Aji over 9 years ago

So the suggestion for this is to use Single Table Inheritance.
Remove the rubocop class length directive.

Actions
Copy link
 #4

Updated by Ian Ballou 8 months ago

  • Target version deleted (Katello Backlog)
Actions
Copy link

Also available in: Atom PDF