Project

General

Profile

Refactor #12979

Add a helper for primary buttons

Added by Alon Goldboim over 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Web Interface
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3396, https://github.com/theforeman/foreman/pull/3350, https://github.com/theforeman/foreman/pull/3373
Fixed in Releases:
Found in Releases:

Description

In most of the views there is a create button(example "New Host") that we need to apply btn-success css class on it(btn-primary once patterfly will be merged), we are now doing so automatically by using JavaScript which is considered bad practice(application.js:66), we need to remove it.

In order to achieve that:
  • create a helper for create_button.
  • apply it in needed views.
  • remove js functionality (application.js:66).

Related issues

Related to Discovery - Refactor #14360: Use new_link for new buttonsClosed2016-03-28
Related to Foreman Remote Execution - Bug #14506: Use new button helpersClosed2016-04-06
Related to Foreman - Bug #14555: Welcome pages missing use of new_link helperClosed2016-04-08
Related to Foreman - Bug #14564: some buttons are no longer visible as buttonsClosed2016-04-11
Related to Foreman - Bug #14977: report show toolbar buttons are just linksClosed2016-05-10
Related to Foreman - Bug #15431: smart proxy show buttons are missing css classes.Closed2016-06-16
Related to Foreman Remote Execution - Bug #15475: btn misses css class under console viewRejected2016-06-21

Associated revisions

Revision bb25ebe6 (diff)
Added by Tomer Brisker about 6 years ago

Fixes #12979 - Create helper for "new" button

Previously the button classes were applied to new buttons using jQuery.
This commit creates a `new_link` helper that makes sure all new buttons
will receive the correct class and only display if authorized. Also a
little bit of cleanup.

Revision 9980268f (diff)
Added by Ori Rabin about 6 years ago

Refs #12979 - adding btn-default class to leftover buttons

Revision 170a3269 (diff)
Added by Tomer Brisker about 6 years ago

Refs #12979 - fix proxy button styling

History

#1 Updated by Tomer Brisker about 6 years ago

  • Category set to Web Interface
  • Status changed from New to Assigned
  • Assignee set to Tomer Brisker

#2 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3350 added

#3 Updated by Anonymous about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ori Rabin about 6 years ago

#5 Updated by Dominic Cleal about 6 years ago

  • Legacy Backlogs Release (now unused) set to 136

#6 Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3373 added

#7 Updated by Stephen Benjamin about 6 years ago

  • Related to Bug #14506: Use new button helpers added

#8 Updated by Dominic Cleal about 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3396 added

#9 Updated by Tomer Brisker about 6 years ago

  • Related to Bug #14555: Welcome pages missing use of new_link helper added

#10 Updated by Ohad Levy about 6 years ago

  • Related to Bug #14564: some buttons are no longer visible as buttons added

#11 Updated by Dominic Cleal about 6 years ago

  • Related to Bug #14977: report show toolbar buttons are just links added

#12 Updated by Dominic Cleal almost 6 years ago

  • Related to Bug #15431: smart proxy show buttons are missing css classes. added

#13 Updated by Ohad Levy almost 6 years ago

  • Related to Bug #15475: btn misses css class under console view added

Also available in: Atom PDF