Actions
Refactor #12979
closed
Add a helper for primary buttons
Difficulty:
Triaged:
Description
In most of the views there is a create button(example "New Host") that we need to apply btn-success css class on it(btn-primary once patterfly will be merged), we are now doing so automatically by using JavaScript which is considered bad practice(application.js:66), we need to remove it.
In order to achieve that:- create a helper for create_button.
- apply it in needed views.
- remove js functionality (application.js:66).
Updated by Tomer Brisker over 7 years ago
- Category set to Web Interface
- Status changed from New to Assigned
- Assignee set to Tomer Brisker
Updated by The Foreman Bot over 7 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3350 added
Updated by Anonymous over 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset bb25ebe661dea99d1247dd48a0dbea5c88162711.
Updated by Ori Rabin over 7 years ago
- Related to Refactor #14360: Use new_link for new buttons added
Updated by Dominic Cleal over 7 years ago
- translation missing: en.field_release set to 136
Updated by The Foreman Bot over 7 years ago
- Pull request https://github.com/theforeman/foreman/pull/3373 added
Updated by Stephen Benjamin over 7 years ago
- Related to Bug #14506: Use new button helpers added
Updated by Dominic Cleal over 7 years ago
- Pull request https://github.com/theforeman/foreman/pull/3396 added
Updated by Tomer Brisker over 7 years ago
- Related to Bug #14555: Welcome pages missing use of new_link helper added
Updated by Ohad Levy over 7 years ago
- Related to Bug #14564: some buttons are no longer visible as buttons added
Updated by Dominic Cleal over 7 years ago
- Related to Bug #14977: report show toolbar buttons are just links added
Updated by Dominic Cleal over 7 years ago
- Related to Bug #15431: smart proxy show buttons are missing css classes. added
Updated by Ohad Levy over 7 years ago
- Related to Bug #15475: btn misses css class under console view added
Actions