Project

General

Profile

Actions
Copy link

Refactor #12979

closed

Add a helper for primary buttons

Added by Alon Goldboim almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Web Interface
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3350, https://github.com/theforeman/foreman/pull/3373, https://github.com/theforeman/foreman/pull/3396
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

In most of the views there is a create button(example "New Host") that we need to apply btn-success css class on it(btn-primary once patterfly will be merged), we are now doing so automatically by using JavaScript which is considered bad practice(application.js:66), we need to remove it.

In order to achieve that:
  • create a helper for create_button.
  • apply it in needed views.
  • remove js functionality (application.js:66).

Related issues 7 (0 open — 7 closed)

Related to Discovery - Refactor #14360: Use new_link for new buttonsClosedOri Rabin03/28/2016Actions
Related to Foreman Remote Execution - Bug #14506: Use new button helpersClosedStephen Benjamin04/06/2016Actions
Related to Foreman - Bug #14555: Welcome pages missing use of new_link helperClosedStephen Benjamin04/08/2016Actions
Related to Foreman - Bug #14564: some buttons are no longer visible as buttonsClosedTomer Brisker04/11/2016Actions
Related to Foreman - Bug #14977: report show toolbar buttons are just linksClosedOndřej Pražák05/10/2016Actions
Related to Foreman - Bug #15431: smart proxy show buttons are missing css classes.ClosedDominic Cleal06/16/2016Actions
Related to Foreman Remote Execution - Bug #15475: btn misses css class under console viewRejected06/21/2016Actions
Actions
Copy link
 #1

Updated by Tomer Brisker almost 9 years ago

  • Category set to Web Interface
  • Status changed from New to Assigned
  • Assignee set to Tomer Brisker
Actions
Copy link
 #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3350 added
Actions
Copy link
 #3

Updated by Anonymous almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Ori Rabin almost 9 years ago

Actions
Copy link
 #5

Updated by Dominic Cleal almost 9 years ago

  • Translation missing: en.field_release set to 136
Actions
Copy link
 #6

Updated by The Foreman Bot almost 9 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3373 added
Actions
Copy link
 #7

Updated by Stephen Benjamin over 8 years ago

  • Related to Bug #14506: Use new button helpers added
Actions
Copy link
 #8

Updated by Dominic Cleal over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3396 added
Actions
Copy link
 #9

Updated by Tomer Brisker over 8 years ago

  • Related to Bug #14555: Welcome pages missing use of new_link helper added
Actions
Copy link
 #10

Updated by Ohad Levy over 8 years ago

  • Related to Bug #14564: some buttons are no longer visible as buttons added
Actions
Copy link
 #11

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #14977: report show toolbar buttons are just links added
Actions
Copy link
 #12

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #15431: smart proxy show buttons are missing css classes. added
Actions
Copy link
 #13

Updated by Ohad Levy over 8 years ago

  • Related to Bug #15475: btn misses css class under console view added
Actions
Copy link

Also available in: Atom PDF