Project

General

Profile

Actions
Copy link

Bug #13074

closed

sprockets-rails dependency should not be in assets.rb only

Added by Dominic Cleal almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Packaging
Target version:
1.11.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3047
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

#4629 partially undid the fix in #12977, by moving the sprockets-rails dependency out of the Gemfile and into assets.rb. sprockets-rails is a runtime dependency and so should stay in Gemfile. #12977 was a runtime error in production.

The sprockets gem is also a runtime dependency, so should be in Gemfile rather than assets.rb.

Related issues 2 (0 open — 2 closed)

Related to Foreman - Feature #4629: Add Patternfly support in foremanClosedAlon Goldboim03/11/2014Actions
Related to Foreman - Bug #12977: sprockets-rails 2.2.2 or higher is needed for production assets setupClosedDominic Cleal01/04/2016Actions
Actions
Copy link
 #1

Updated by Dominic Cleal almost 9 years ago

  • Related to Feature #4629: Add Patternfly support in foreman added
Actions
Copy link
 #2

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #12977: sprockets-rails 2.2.2 or higher is needed for production assets setup added
Actions
Copy link
 #3

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3047 added
Actions
Copy link
 #4

Updated by Daniel Lobato Garcia almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF