Project

General

Profile

Bug #13074

sprockets-rails dependency should not be in assets.rb only

Added by Dominic Cleal over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

#4629 partially undid the fix in #12977, by moving the sprockets-rails dependency out of the Gemfile and into assets.rb. sprockets-rails is a runtime dependency and so should stay in Gemfile. #12977 was a runtime error in production.

The sprockets gem is also a runtime dependency, so should be in Gemfile rather than assets.rb.


Related issues

Related to Foreman - Feature #4629: Add Patternfly support in foremanClosed2014-03-11
Related to Foreman - Bug #12977: sprockets-rails 2.2.2 or higher is needed for production assets setupClosed2016-01-04

Associated revisions

Revision 24f70e14 (diff)
Added by Daniel Lobato Garcia over 3 years ago

Fixes #13074 - sprockets-rails should be in Gemfile

dependency out of the Gemfile and into assets.rb. sprockets-rails is a
runtime dependency and so should stay in Gemfile. #12977 was a runtime
error in production.

The sprockets gem is also a runtime dependency, so should be in Gemfile
rather than assets.rb.

History

#1 Updated by Dominic Cleal over 3 years ago

  • Related to Feature #4629: Add Patternfly support in foreman added

#2 Updated by Dominic Cleal over 3 years ago

  • Related to Bug #12977: sprockets-rails 2.2.2 or higher is needed for production assets setup added

#3 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3047 added

#4 Updated by Daniel Lobato Garcia over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF