Project

General

Profile

Bug #13130

Only one template invocation is created per one job invocation

Added by Marek Hulán over 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

During digging around job_name refactoring I realized that template invocations are not being created as expected. Job composer creates one template invocation that works as a template (does not have host_id yet, that is correct), then when planning the RunHostJob the same template is passed as an argument, during plan host_id is set. Unfortunately for all RunHostJob the same template is used, so each sub task is changing the only one template invocation that exist. We should expand the template as part of RunHostsJob so it passes new object to RunHostJob. I guess the update was part of RunHostJob plan phase, since that's in transaction.

Associated revisions

Revision 1206a1c4 (diff)
Added by Marek Hulán over 6 years ago

Fixes #13130 - save template invocations for each host

This commit introduces so called pattern template invocation which is
created by job composer as a pattern for real template invocation that
being created during dynflow action run. Pattern template invocation
holds all information from composer (e.g. input values) except target
host which is evaluated just during dynflow action run phase.

Revision 6c3040af
Added by Marek Hulán over 6 years ago

Merge pull request #117 from ares/fix/13130

Fixes #13130 - save template invocations for each host

History

#1 Updated by Marek Hulán over 6 years ago

  • Status changed from New to Assigned

#2 Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/117 added

#3 Updated by Marek Hulán over 6 years ago

  • Legacy Backlogs Release (now unused) set to 109

#4 Updated by Marek Hulán over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF