Project

General

Profile

Refactor #13133

Improve readability of provided job templates

Added by Marek Hulán over 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Stephen Benjamin
Category:
-
Target version:
foreman_remote_execution 0.3.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_remote_execution/pull/152
Fixed in Releases:
Found in Releases:

Description

extract common bash functions to some snippet (e.g. die function), maybe add a commentary so it's not the first thing that user see

Associated revisions

Revision 4eba7de1 (diff)
Added by Stephen Benjamin over 6 years ago

fixes #13133, #13632 - improve package action template

This change renames the 'die' function to 'exit_with_message' as some
users found it particularly terrifying to see this as the first line in
the template preview. It also adds documentation to the function.

Secondly, it causes the package action template to fail more gracefully
when a host has no operating system, or an unsupported one.

Revision 29714e7e
Added by Stephen Benjamin over 6 years ago

Merge pull request #152 from stbenjam/package-action-improvements

fixes #13133, #13632 - improve package action template

History

#1 Updated by Ivan Necas over 6 years ago

  • Target version set to 98

#2 Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Stephen Benjamin
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/152 added

#3 Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Marek Hulán over 6 years ago

  • Legacy Backlogs Release (now unused) set to 125

Also available in: Atom PDF