Project

General

Profile

Actions

Bug #13157

closed

Left padding on status icons is too much on host index and show pages

Added by Dominic Cleal almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The fix for #13075 affected every page that uses status icons as well as text, it wasn't confined in any way to the padding between the icon and text on host#show.

Two instances of this:

1. The status icons and host names on hosts#index are now indented too far to the left, so the padding around the whole cell (top-left-bottom) is inconsistent.

2. The status icons on host#show are now out of line with the text in the cells below.

It has fixed the padding between icon and text, but the same class that was changed is applied to the icon as well as the text.


Files

Screenshot from 2016-01-12 15-19-39.png View Screenshot from 2016-01-12 15-19-39.png 8.97 KB index after Dominic Cleal, 01/12/2016 10:25 AM
Screenshot from 2016-01-12 15-19-59.png View Screenshot from 2016-01-12 15-19-59.png 8.81 KB index before Dominic Cleal, 01/12/2016 10:25 AM
Screenshot from 2016-01-12 15-21-34.png View Screenshot from 2016-01-12 15-21-34.png 10.6 KB show after Dominic Cleal, 01/12/2016 10:25 AM
Screenshot from 2016-01-12 15-21-45.png View Screenshot from 2016-01-12 15-21-45.png 10.5 KB show before Dominic Cleal, 01/12/2016 10:25 AM

Related issues 1 (0 open1 closed)

Related to Foreman - Bug #13075: Missing padding between host#show status icon and captionClosedAlon Goldboim01/08/2016Actions
Actions #1

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #13075: Missing padding between host#show status icon and caption added
Actions #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tom Caspy
  • Pull request https://github.com/theforeman/foreman/pull/3139 added
Actions #3

Updated by Tom Caspy almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF