Project

General

Profile

Bug #13157

Left padding on status icons is too much on host index and show pages

Added by Dominic Cleal about 3 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The fix for #13075 affected every page that uses status icons as well as text, it wasn't confined in any way to the padding between the icon and text on host#show.

Two instances of this:

1. The status icons and host names on hosts#index are now indented too far to the left, so the padding around the whole cell (top-left-bottom) is inconsistent.

2. The status icons on host#show are now out of line with the text in the cells below.

It has fixed the padding between icon and text, but the same class that was changed is applied to the icon as well as the text.

Screenshot from 2016-01-12 15-19-39.png View Screenshot from 2016-01-12 15-19-39.png 8.97 KB index after Dominic Cleal, 01/12/2016 10:25 AM
Screenshot from 2016-01-12 15-19-59.png View Screenshot from 2016-01-12 15-19-59.png 8.81 KB index before Dominic Cleal, 01/12/2016 10:25 AM
Screenshot from 2016-01-12 15-21-34.png View Screenshot from 2016-01-12 15-21-34.png 10.6 KB show after Dominic Cleal, 01/12/2016 10:25 AM
Screenshot from 2016-01-12 15-21-45.png View Screenshot from 2016-01-12 15-21-45.png 10.5 KB show before Dominic Cleal, 01/12/2016 10:25 AM
Screenshot%20from%202016 01 12%2015 19 39 Screenshot%20from%202016 01 12%2015 19 59 Screenshot%20from%202016 01 12%2015 21 34 Screenshot%20from%202016 01 12%2015 21 45

Related issues

Related to Foreman - Bug #13075: Missing padding between host#show status icon and captionClosed2016-01-08

Associated revisions

Revision a80e0589 (diff)
Added by Tom Caspy almost 3 years ago

fixes #13157 - adding padding to icons in hosts#show

History

#1 Updated by Dominic Cleal about 3 years ago

  • Related to Bug #13075: Missing padding between host#show status icon and caption added

#2 Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tom Caspy
  • Pull request https://github.com/theforeman/foreman/pull/3139 added

#3 Updated by Tom Caspy almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF