Project

General

Profile

Refactor #13310

Unify deep_clone and deep_clone! methods

Added by Marek Hulán almost 3 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

In template invocations we have two methods, job_invocation only defines method without bang but it runs save!. We should have both in both objects. Also template_invocation #deep_clone! should call save! on template_invocation, not the inputs.

Associated revisions

Revision 32447931 (diff)
Added by Adam Ruzicka over 2 years ago

Fixes #13310 - Provide deep_clone and deep_clone!

Revision f238e4bf
Added by Marek Hulán over 2 years ago

Merge pull request #162 from adamruzicka/fix/13310-deep-clone

Fixes #13310 - Provide deep_clone and deep_clone!

History

#1 Updated by Ivan Necas over 2 years ago

  • Target version set to 98

#2 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/162 added

#3 Updated by Ivan Necas over 2 years ago

  • Target version changed from 98 to 99

#4 Updated by Marek Hulán over 2 years ago

  • Legacy Backlogs Release (now unused) set to 138

#5 Updated by Adam Ruzicka over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF