Actions
Bug #13427
closed
Progname not defined for SYSLOG logger
Difficulty:
trivial
Triaged:
Bugzilla link:
Pull request:
Description
According to Ruby API (http://ruby-doc.org/stdlib-2.1.0/libdoc/logger/rdoc/Logger.html#method-i-add) if both message and block are missing, progname should be treated as the message. The code in log decorator (buffer) has a bug that was working incorrectly. This shows up if there is SYSLOG logger configured and an error occurs:
/usr/share/foreman-proxy/lib/proxy/log_buffer/decorator.rb:19:in `add': undefined method `progname' for #<Syslog::Logger:0x0000000204a8b0> (NoMethodError)
from /usr/share/foreman-proxy/lib/proxy/log_buffer/decorator.rb:50:in `error'
from /usr/share/foreman-proxy/lib/launcher.rb:135:in `rescue in launch'
from /usr/share/foreman-proxy/lib/launcher.rb:110:in `launch'
from bin/smart-proxy:6:in `<main>'
Updated by The Foreman Bot almost 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/370 added
Updated by Lukas Zapletal almost 9 years ago
- Translation missing: en.field_release set to 71
I need this to be included in the 1.11 release, discovery image does not work without this patch. Thanks!
Updated by Anonymous almost 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset a838204ef2e21b9c3e89db84894b35a7af059d18.
Actions