Project

General

Profile

Actions

Refactor #13440

closed

Replace Host::Base#model_name to prevent Rails 4.2 conflict

Added by Dominic Cleal about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Rails 4.2 implements #model_name in ActiveRecord::Base as an instance method rather than a class method (in 4.1 and older), changed in https://github.com/rails/rails/commit/6b0e834.

Our HasManyCommon concern adds a model_name method to Host::Base as an extension of the model/model_id association to the Model er, model. This will need to be removed to ensure the AR method continues to work.

When our model is in place, links to hosts can't be generated in Rails 4.2 as they return nil or string values from our implementation Host::Base#model_name rather than the ActiveModel::Name object expected.


Related issues 3 (0 open3 closed)

Related to Discovery - Bug #14227: Discovery mailer fails for hosts without model nameClosedLukas Zapletal03/16/2016Actions
Related to Discovery - Refactor #14236: Rename model_name to hardware_model_nameDuplicateLukas Zapletal03/16/2016Actions
Blocks Foreman - Feature #13244: Upgrade Ruby on Rails to 4.2ClosedDominic Cleal01/15/2016Actions
Actions #1

Updated by Dominic Cleal about 8 years ago

Actions #2

Updated by The Foreman Bot about 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3133 added
Actions #3

Updated by Dominic Cleal about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 8 years ago

  • translation missing: en.field_release set to 71
Actions #5

Updated by Dominic Cleal about 8 years ago

  • Related to Bug #14227: Discovery mailer fails for hosts without model name added
Actions #6

Updated by Lukas Zapletal about 8 years ago

  • Related to Refactor #14236: Rename model_name to hardware_model_name added
Actions

Also available in: Atom PDF