Project

General

Profile

Bug #13557

Enforce specifying a time zone via Rubocop

Added by Daniel Lobato Garcia over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Rubocop can enforce what timezone to store in the database via Rubocop, so we can ensure everything is stored using UTC and we don't miss these things in code reviews. When objects are displayed, they must use the time provided by set_timezone in the controller.

This is particularly relevant for Trends, Puppet graphs, etc... to ensure they are stored always properly.

Associated revisions

Revision a977bd3b (diff)
Added by Daniel Lobato Garcia over 3 years ago

Fixes #13557 - Rubocop enforce specifying a timezone

Rubocop can enforce what timezone to store in the database ,
so we can ensure everything is stored using UTC and we don't
miss these things in code reviews. When objects are displayed,
they must use the time provided by set_timezone in the
controller.

This is particularly relevant for Trends, Puppet graphs, etc... to
ensure they are stored always properly

History

#1 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3156 added

#2 Updated by Daniel Lobato Garcia over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 71

Also available in: Atom PDF