Project

General

Profile

Actions
Copy link

Bug #13557

closed

Enforce specifying a time zone via Rubocop

Added by Daniel Lobato Garcia almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Web Interface
Target version:
1.11.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3156
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Rubocop can enforce what timezone to store in the database via Rubocop, so we can ensure everything is stored using UTC and we don't miss these things in code reviews. When objects are displayed, they must use the time provided by set_timezone in the controller.

This is particularly relevant for Trends, Puppet graphs, etc... to ensure they are stored always properly.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3156 added
Actions
Copy link
 #2

Updated by Daniel Lobato Garcia almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Dominic Cleal almost 9 years ago

  • Translation missing: en.field_release set to 71
Actions
Copy link

Also available in: Atom PDF