Refactor #13593
Preload assets before sprockets
Difficulty:
Triaged:
No
Description
Currently Foreman core has an initializer (assets_paths) that takes care of finding the Discovery assets in the engine and load them before sprockets is loaded. This is happening because sprockets tries to load the assets before they are defined (:after => finisher_hook is too late).
Just changing it to :before finisher_hook is enough to make it load assets before then and the deprecation error will go away.
Associated revisions
History
#1
Updated by The Foreman Bot about 7 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman_discovery/pull/247 added
#2
Updated by Daniel Lobato Garcia about 7 years ago
Updated by - Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman_discovery|e4a44fc90ca3098ddcef44ce8bdf861c4ef7a648.
Fixes #13593 - Preload assets before sprockets
Currently Foreman core has an initializer (assets_paths) that takes care
of finding the Discovery assets in the engine and load them before
sprockets is loaded. This is happening because sprockets tries to load
the assets before they are defined (:after => finisher_hook is too
late).
Just changing it to :before finisher_hook is enough to make it load
assets before then and the deprecation error will go away.