Project

General

Profile

Refactor #13593

Preload assets before sprockets

Added by Daniel Lobato Garcia about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Discovery plugin
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently Foreman core has an initializer (assets_paths) that takes care of finding the Discovery assets in the engine and load them before sprockets is loaded. This is happening because sprockets tries to load the assets before they are defined (:after => finisher_hook is too late).

Just changing it to :before finisher_hook is enough to make it load assets before then and the deprecation error will go away.

Associated revisions

Revision e4a44fc9 (diff)
Added by Daniel Lobato Garcia about 7 years ago

Fixes #13593 - Preload assets before sprockets

Currently Foreman core has an initializer (assets_paths) that takes care
of finding the Discovery assets in the engine and load them before
sprockets is loaded. This is happening because sprockets tries to load
the assets before they are defined (:after => finisher_hook is too
late).

Just changing it to :before finisher_hook is enough to make it load
assets before then and the deprecation error will go away.

History

#1 Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/247 added

#2 Updated by Daniel Lobato Garcia about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF