Bug #13841
closedSmart Proxy DNS nsupdate GSS fails
Description
Unable to configure DNS provider nsupdate GSS.
Smart Proxy errors with the following:
E, [2016-02-22T17:09:14.944969 #18936] ERROR -- : wrong number of arguments (0 for 1)
D, [2016-02-22T17:09:14.945003 #18936] DEBUG -- : wrong number of arguments (0 for 1) (ArgumentError)
/usr/share/foreman-proxy/modules/dns_nsupdate/dns_nsupdate_gss_main.rb:20:in `nsupdate_connect'
/usr/share/foreman-proxy/modules/dns_nsupdate/dns_nsupdate_main.rb:24:in `do_create'
/usr/share/foreman-proxy/modules/dns_nsupdate/dns_nsupdate_main.rb:16:in `create_a_record'
This is due to the fact that nsupdate_connect definition (in dns_nsupdate_gss_main.rb) includes a parameter and it is not called with one (in dns_nsupdate_main.rb).
Looking at stable version 1.10 it appears the code was split from a general nsupdate definition which required parameter cmd (either connect or disconnect). The new nsupdate_connect definition was still coded with the parameter but in usage no parameter was specified.
I worked around this issue by just modifying the definition signature to
def nsupdate_connect
..
end
As the inherited method wasn't expecting a parameter either.
Updated by Anonymous over 8 years ago
- Project changed from Katello to Smart Proxy
- Category set to DNS
Updated by Dominic Cleal over 8 years ago
- Translation missing: en.field_release set to 71
Your patch is correct - if you'd like to send it in, please open a pull request to https://github.com/theforeman/smart-proxy/ per the instructions on http://theforeman.org/contribute.html#Code-relatedcontributions.
Updated by The Foreman Bot over 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/385 added
Updated by Anonymous over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 7e896ba914b8fee0e52e29d10119b4d7d1f44a28.