Foreman » Smart Proxy

Fix for #13536 / PR379¹ introduced a method to check for ptr collisions. It relies on Resolv.getnames² to detect existing records:

Currently, Resolv.getnames(<reverse resolvable IPv6 address>) always returns an empty array [], while nslookup resolves the name fine. This might be an upstream issue?

This leads to the following issues for smart-proxy:

• Method always returns no conflict
• Overwriting PTRs fail in #execute
• Collisions fail in #execute, as another PTR exists

Relevant method ptr_record_conflicts²

# [..]
def resolver
   Resolv::DNS.new(:nameserver => @server)
end

# [..]

# conflict methods return values:
# no conflict: -1; conflict: 1, conflict but record / ip matches: 0
def ptr_record_conflicts(fqdn, ip)
  names = resolver.getnames(ip_addr.to_s)
  return -1 if names.empty?
  return 0 if names.any? {|n| n.to_s.casecmp(fqdn) == 0}
  1
# [..]

[1] https://github.com/theforeman/smart-proxy/pull/379
[2] https://github.com/theforeman/smart-proxy/blob/develop/modules/dns_common/dns_common.rb#L54