Project

General

Profile

Actions

Refactor #13913

closed

Split importing of host and facts into separate methods

Added by Marek Hulán about 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Importers
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Host#import_host_and_facts does to many things. While importing host is class responsibility, facts importing is host instance responsibility. This makes it hard if plugins like foreman-tasks wants to make facts importing a background process while keeping host importing as is. In fact it makes the foreman tasks plugin to re-implement the importing which gets out of sync every now and then.


Related issues 1 (0 open1 closed)

Related to Discovery - Refactor #13914: Split import_hosts_and_factsClosedLukas Zapletal02/26/2016Actions
Actions #1

Updated by The Foreman Bot about 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3242 added
Actions #2

Updated by Lukas Zapletal about 8 years ago

Actions #3

Updated by Marek Hulán about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 8 years ago

  • translation missing: en.field_release set to 136
Actions

Also available in: Atom PDF