Project

General

Profile

Actions
Copy link

Refactor #13978

closed

Replace AR connection value_to_boolean method with Foreman::Cast

Added by Dominic Cleal almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Rails
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3276
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The host common #lookup_values_attributes= method uses an internal Active Record method value_to_boolean to parse the _destroy parameter from the nested attributes supplied by the UI.

https://github.com/theforeman/foreman/blob/1.11.0-RC1/app/models/concerns/host_common.rb#L54-L58

This method has been moved in Rails 4.2 and since it's really rather internal, it should be replaced by Foreman::Cast.to_bool or similar.

Related issues 1 (0 open — 1 closed)

Blocks Foreman - Feature #13244: Upgrade Ruby on Rails to 4.2ClosedDominic Cleal01/15/2016Actions
Actions
Copy link
 #1

Updated by Dominic Cleal almost 9 years ago

Actions
Copy link
 #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Dominic Cleal
  • Pull request https://github.com/theforeman/foreman/pull/3276 added
Actions
Copy link
 #3

Updated by Dominic Cleal almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Dominic Cleal almost 9 years ago

  • Translation missing: en.field_release set to 136
Actions
Copy link

Also available in: Atom PDF