Actions
Refactor #13978
closedReplace AR connection value_to_boolean method with Foreman::Cast
Description
The host common #lookup_values_attributes= method uses an internal Active Record method value_to_boolean to parse the _destroy parameter from the nested attributes supplied by the UI.
https://github.com/theforeman/foreman/blob/1.11.0-RC1/app/models/concerns/host_common.rb#L54-L58
This method has been moved in Rails 4.2 and since it's really rather internal, it should be replaced by Foreman::Cast.to_bool or similar.
Updated by Dominic Cleal over 8 years ago
- Blocks Feature #13244: Upgrade Ruby on Rails to 4.2 added
Updated by The Foreman Bot over 8 years ago
- Status changed from New to Ready For Testing
- Assignee set to Dominic Cleal
- Pull request https://github.com/theforeman/foreman/pull/3276 added
Updated by Dominic Cleal over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 904367f1e2da6738d11dc5231c0a91fdcf088c6f.
Updated by Dominic Cleal over 8 years ago
- Translation missing: en.field_release set to 136
Actions