Project

General

Profile

Bug #14001

Wrapping `host.save` call into external trasnaction causes the `post_commit` orchestration to be triggered even when failures in `pre_commit` orchestration

Added by Ivan Necas over 7 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Orchestration
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

This was discovered in a foreman discovery plugin, where the controllers were
wrapped in explicit transactions (which itself should not be considered harmful).
However, trying to do this, the post_commit orchestration gets triggered
even if the pre_commit phase fails and rolls back.

I'm filling this bug in mainly for tracking the limitations of the current
orchestration that has not simple solution without rethinking the way
we do the provisioning orchestration.


Related issues

Related to Discovery - Bug #12256: Rollback during discovered host provisioning errors with ERF42-8175 and causes post_commit orchestrationClosed2015-10-22
Related to Foreman - Tracker #14002: Orchestration build around ActiveRecord hooks trackerNew2016-03-02

History

#1 Updated by Ivan Necas over 7 years ago

  • Related to Bug #12256: Rollback during discovered host provisioning errors with ERF42-8175 and causes post_commit orchestration added

#2 Updated by Ivan Necas over 7 years ago

  • Related to Bug #13766: SSH-based provisioning doesn't trigger IP address validation added

#3 Updated by Ivan Necas over 7 years ago

  • Related to deleted (Bug #13766: SSH-based provisioning doesn't trigger IP address validation)

#4 Updated by Ivan Necas over 7 years ago

  • Related to Tracker #14002: Orchestration build around ActiveRecord hooks tracker added

#5 Updated by Lukas Zapletal over 2 years ago

This appears to be fixed in Rails 6: https://github.com/rails/rails/issues/29747

I haven't tested tho.

Also available in: Atom PDF