Project

General

Profile

Actions
Copy link

Refactor #14006

closed

Mailers calling *_path with :only_path => false should use _url helpers

Added by Dominic Cleal over 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
E-Mail
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3271
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

All mailers that use *_path helpers and pass :only_path => false to get a URL should be changed to use *_url helpers instead, as this is deprecated in Rails 4.2.

http://edgeguides.rubyonrails.org/4_2_release_notes.html#action-pack-deprecations

Related issues 1 (0 open — 1 closed)

Related to Foreman - Refactor #15847: URL helpers must be used in mailersClosedDominic Cleal07/27/2016Actions
Actions
Copy link
 #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Dominic Cleal
  • Pull request https://github.com/theforeman/foreman/pull/3271 added
Actions
Copy link
 #2

Updated by Dominic Cleal over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Dominic Cleal over 9 years ago

  • Translation missing: en.field_release set to 136
Actions
Copy link
 #4

Updated by Dominic Cleal almost 9 years ago

Actions
Copy link

Also available in: Atom PDF