Project

General

Profile

Refactor #14006

Mailers calling *_path with :only_path => false should use _url helpers

Added by Dominic Cleal over 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
E-Mail
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

All mailers that use *_path helpers and pass :only_path => false to get a URL should be changed to use *_url helpers instead, as this is deprecated in Rails 4.2.

http://edgeguides.rubyonrails.org/4_2_release_notes.html#action-pack-deprecations


Related issues

Related to Foreman - Refactor #15847: URL helpers must be used in mailersClosed2016-07-27

Associated revisions

Revision eedc8706 (diff)
Added by Dominic Cleal over 5 years ago

fixes #14006 - use URL helpers in mailers

Rails 4.2 deprecates mailers from using _path helpers and from path
helpers being called with only_path => false. They should all be
changed to use _url helpers.

History

#1 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Dominic Cleal
  • Pull request https://github.com/theforeman/foreman/pull/3271 added

#2 Updated by Dominic Cleal over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 136

#4 Updated by Dominic Cleal about 5 years ago

Also available in: Atom PDF