Bug #14045: select2 dropdown boxes don't match inherit button heights - Foreman

Actions

Copy link

Bug #14045

closed

select2 dropdown boxes don't match inherit button heights

Added by Dominic Cleal over 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ori Rabin

Category:

Web Interface

Target version:

1.10.3

Difficulty:

Triaged:

Bugzilla link:

1326033

Pull request:

https://github.com/theforeman/foreman/pull/3279, https://github.com/theforeman/foreman/pull/3280

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

select2-rails 3.5.10 was released which has slightly broken the formatting of the dropdown menus, most noticeably on the New Host form.

The height of the select boxes no longer matches the height of the adjacent "inherit" buttons on the first page of the New Host forms.

Setting to 1.10.3 as this'll affect all branches due to the pinning on select2-rails. The effect on 1.10-stable is even worse.

Files

Screenshot from 2016-03-03 15-50-24.png	View Screenshot from 2016-03-03 15-50-24.png	9.68 KB	select2-rails 3.5.9 on develop	Dominic Cleal, 03/03/2016 10:55 AM
Screenshot from 2016-03-03 15-48-58.png	View Screenshot from 2016-03-03 15-48-58.png	10.1 KB	select2-rails 3.5.10 on develop, size mismatch	Dominic Cleal, 03/03/2016 10:55 AM
Screenshot from 2016-03-03 15-54-51.png	View Screenshot from 2016-03-03 15-54-51.png	9.29 KB	select2-rails 3.5.10 on 1.10-stable, background mismatch	Dominic Cleal, 03/03/2016 10:56 AM

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Translation missing: en.field_release changed from 145 to 136

I think we should probably pin this at 3.5.9.x for 1.10-stable and 1.11-stable branches to keep the UIs stable, then adapt the theme on develop and probably update to 4.x.

I guess the select2-bootstrap theme shipped with select2 isn't working reliably since #4629 changes the field sizes, so it may need supplementing with another set of overrides or an additional theme.

Actions

Copy link