Project

General

Profile

Bug #14045

select2 dropdown boxes don't match inherit button heights

Added by Dominic Cleal over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:

Description

select2-rails 3.5.10 was released which has slightly broken the formatting of the dropdown menus, most noticeably on the New Host form.

The height of the select boxes no longer matches the height of the adjacent "inherit" buttons on the first page of the New Host forms.

Setting to 1.10.3 as this'll affect all branches due to the pinning on select2-rails. The effect on 1.10-stable is even worse.

Screenshot from 2016-03-03 15-50-24.png View Screenshot from 2016-03-03 15-50-24.png 9.68 KB select2-rails 3.5.9 on develop Dominic Cleal, 03/03/2016 10:55 AM
Screenshot from 2016-03-03 15-48-58.png View Screenshot from 2016-03-03 15-48-58.png 10.1 KB select2-rails 3.5.10 on develop, size mismatch Dominic Cleal, 03/03/2016 10:55 AM
Screenshot from 2016-03-03 15-54-51.png View Screenshot from 2016-03-03 15-54-51.png 9.29 KB select2-rails 3.5.10 on 1.10-stable, background mismatch Dominic Cleal, 03/03/2016 10:56 AM
Screenshot%20from%202016 03 03%2015 50 24 Screenshot%20from%202016 03 03%2015 48 58 Screenshot%20from%202016 03 03%2015 54 51

Associated revisions

Revision a3a7f02a (diff)
Added by Ori Rabin over 5 years ago

Fixes #14045 - change inherit button height to match select2

Revision 5edc74bb (diff)
Added by Ori Rabin over 5 years ago

Fixes #14045 - resizing select2 to match inherit button

Revision e3305173 (diff)
Added by Dominic Cleal over 5 years ago

refs #14045 - pin select2-rails to 3.5.10

Revision 3d44ccf2 (diff)
Added by Ori Rabin over 5 years ago

Fixes #14045 - resizing select2 to match inherit button

(cherry picked from commit 5edc74bbd2b8c03624c339439d361d0800e4468c)

History

#1 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) changed from 145 to 136

I think we should probably pin this at 3.5.9.x for 1.10-stable and 1.11-stable branches to keep the UIs stable, then adapt the theme on develop and probably update to 4.x.

I guess the select2-bootstrap theme shipped with select2 isn't working reliably since #4629 changes the field sizes, so it may need supplementing with another set of overrides or an additional theme.

#2 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) changed from 136 to 145

#3 Updated by Ori Rabin over 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Ori Rabin

#4 Updated by The Foreman Bot over 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3279 added

#5 Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3280 added

#6 Updated by Ori Rabin over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Bryan Kearney over 5 years ago

  • Bugzilla link set to 1326033

Also available in: Atom PDF