Project

General

Profile

Bug #14114

Rake tasks fail under rake 11.x with undefined method `last_comment'

Added by Dominic Cleal over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
rake tasks
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Since rake 11.x was released, rake tasks are failing with the following:

NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00000000cc8350>
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/rubocop-0.35.1/lib/rubocop/rake_task.rb:23:in `initialize'
/var/lib/workspace/workspace/test_develop/database/postgresql/ruby/2.1/slave/fast/lib/tasks/rubocop.rake:5:in `new'
/var/lib/workspace/workspace/test_develop/database/postgresql/ruby/2.1/slave/fast/lib/tasks/rubocop.rake:5:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/activesupport-4.1.14.2/lib/active_support/dependencies.rb:241:in `load'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/activesupport-4.1.14.2/lib/active_support/dependencies.rb:241:in `block in load'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/activesupport-4.1.14.2/lib/active_support/dependencies.rb:232:in `load_dependency'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/activesupport-4.1.14.2/lib/active_support/dependencies.rb:241:in `load'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/engine.rb:654:in `block in run_tasks_blocks'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/engine.rb:654:in `each'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/engine.rb:654:in `run_tasks_blocks'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/application.rb:400:in `run_tasks_blocks'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/engine.rb:449:in `load_tasks'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/railtie.rb:194:in `public_send'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/gems/railties-4.1.14.2/lib/rails/railtie.rb:194:in `method_missing'
/var/lib/workspace/workspace/test_develop/database/postgresql/ruby/2.1/slave/fast/Rakefile:7:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-2.1.5@test_develop-1/bin/ruby_executable_hooks:15:in `<main>'

This is a bug in rubocop to be fixed in https://github.com/bbatsov/rubocop/pull/2931. In the meantime and for stable branches, the version of rake should probably be pinned to avoid updating rubocop.


Related issues

Related to Foreman - Feature #14133: Update to rubocop 0.38.0Closed2016-03-10

Associated revisions

Revision d29a748f (diff)
Added by Dominic Cleal over 3 years ago

fixes #14114 - pin rake to avoid rubocop/rake 11.x incompatibility

Revision 3ae0b2f1 (diff)
Added by Dominic Cleal over 3 years ago

fixes #14114 - pin rake to avoid rubocop/rake 11.x incompatibility

(cherry picked from commit d29a748f6653bcae41272d9faa1aae61a4bcfb6e)

Revision ae2a32b6 (diff)
Added by Dominic Cleal over 3 years ago

fixes #14114 - pin rake to avoid rubocop/rake 11.x incompatibility

(cherry picked from commit d29a748f6653bcae41272d9faa1aae61a4bcfb6e)

Revision 6d08b855 (diff)
Added by Dominic Cleal over 3 years ago

fixes #14114 - pin rake to avoid rubocop/rake 11.x incompatibility

(cherry picked from commit d29a748f6653bcae41272d9faa1aae61a4bcfb6e)

Revision 3cc82aee (diff)
Added by Dominic Cleal over 3 years ago

fixes #14114 - pin rake to avoid rubocop/rake 11.x incompatibility

(cherry picked from commit d29a748f6653bcae41272d9faa1aae61a4bcfb6e)

History

#1 Updated by Dominic Cleal over 3 years ago

  • Subject changed from Rake tasks fail under rake 1.11 with undefined method `last_comment' to Rake tasks fail under rake 11.x with undefined method `last_comment'
  • Description updated (diff)

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3298 added

#3 Updated by Dominic Cleal over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 3 years ago

#5 Updated by Bryan Kearney over 3 years ago

  • Bugzilla link set to 1326032

Also available in: Atom PDF