Project

General

Profile

Bug #14134

Rake tasks fail under rake 11.x with undefined method `last_comment'

Added by Dominic Cleal over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

As with Foreman in #14114, rake 11.x causes the following error with rubocop pre-0.38.0:

NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000000019f30c0>
/usr/local/rvm/gems/ruby-1.9.3-p392@test_proxy_develop_pr_core-1/gems/rubocop-0.37.1/lib/rubocop/rake_task.rb:24:in `initialize'
tasks/rubocop.rake:4:in `new'
tasks/rubocop.rake:4:in `<top (required)>'
/var/lib/workspace/workspace/test_proxy_develop_pr_core/puppet/3.2.0/ruby/1.9.3/Rakefile:11:in `load'
/var/lib/workspace/workspace/test_proxy_develop_pr_core/puppet/3.2.0/ruby/1.9.3/Rakefile:11:in `<top (required)>'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_proxy_develop_pr_core-1/bin/ruby_noexec_wrapper:14:in `eval'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_proxy_develop_pr_core-1/bin/ruby_noexec_wrapper:14:in `<main>'

On Ruby 1.8.7, rake 11.x also can't be installed as it's now 1.9.3+ only:

Installing rake 11.0.1
Gem::InstallError: rake requires Ruby version >= 1.9.3.

Related issues

Related to Smart Proxy - Bug #14159: Excessively verbose output when executing testsClosed2016-03-11

Associated revisions

Revision 537a4624 (diff)
Added by Dominic Cleal over 3 years ago

fixes #14134 - update rubocop and pin for rake 11.x compatibility

History

#1 Updated by The Foreman Bot over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/391 added

#2 Updated by Dominic Cleal over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 145

#4 Updated by Dominic Cleal over 3 years ago

  • Related to Bug #14159: Excessively verbose output when executing tests added

Also available in: Atom PDF