Project

General

Profile

Actions

Bug #14140

closed

Arbitrary Ruby code execution via Discovery setting

Added by Lukas Zapletal almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Image
Target version:
Difficulty:
trivial
Triaged:
Fixed in Releases:
Found in Releases:

Description

We have couple of evals during review of new Discovery Show page:

https://github.com/lzap/foreman_discovery/blob/fact-clear-14100/app/controllers/discovered_hosts_controller.rb#L188-L193

You can run arbitrary Ruby code by entering it on the About - Settings - Discovery and then visiting a discovered host detail page where it gets rendered.

Actions #1

Updated by Lukas Zapletal almost 9 years ago

  • Description updated (diff)
Actions #2

Updated by Lukas Zapletal almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee changed from Lukas Zapletal to Alon Goldboim
  • Pull request https://github.com/theforeman/foreman_discovery/pull/260 added
Actions #3

Updated by Dominic Cleal almost 9 years ago

  • Private changed from Yes to No

Marking as public as it's been referenced in the associated pull request.

Lukas has also reported it to foreman-security and since this only affects the version of Discovery that's used with a release candidate version of Foreman, no CVE will be assigned as it's generally pre-release. The issue should be resolved in time for 1.11.0's release and it should be documented on http://theforeman.org/security.html.

Actions #4

Updated by Lukas Zapletal almost 9 years ago

  • Status changed from Ready For Testing to Resolved

Merged into develop and 5.0 series, bugfix release by EOBW.

Actions

Also available in: Atom PDF