Project

General

Profile

Refactor #14156

Support Ruby on Rails 4.2 without Foreigner

Added by Dominic Cleal over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Katello's tests fail under Foreman's rails42 branch:

12:44:51 + bundle exec rake db:drop db:create
12:44:57 warning: parser/current is loading parser/ruby22, which recognizes
12:44:57 warning: 2.2.4-compliant syntax, but you are running 2.2.3.
12:44:57 warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
12:44:58 rake aborted!
12:44:58 LoadError: cannot load such file -- foreigner
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `block in require'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:240:in `load_dependency'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
12:44:58 /var/lib/workspace/workspace/test_katello_core/database/postgresql/ruby/2.2/slave/fast/plugin/lib/katello.rb:8:in `<top (required)>'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler/runtime.rb:77:in `require'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler/runtime.rb:77:in `block (2 levels) in require'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler/runtime.rb:72:in `each'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler/runtime.rb:72:in `block in require'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler/runtime.rb:61:in `each'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler/runtime.rb:61:in `require'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/gems/bundler-1.11.2/lib/bundler.rb:99:in `require'
12:44:58 /var/lib/workspace/workspace/test_katello_core/database/postgresql/ruby/2.2/slave/fast/foreman/config/application.rb:25:in `<top (required)>'
12:44:58 /var/lib/workspace/workspace/test_katello_core/database/postgresql/ruby/2.2/slave/fast/foreman/Rakefile:1:in `require'
12:44:58 /var/lib/workspace/workspace/test_katello_core/database/postgresql/ruby/2.2/slave/fast/foreman/Rakefile:1:in `<top (required)>'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/bin/ruby_executable_hooks:15:in `eval'
12:44:58 /usr/local/rvm/gems/ruby-2.2.3@test_katello_core-1/bin/ruby_executable_hooks:15:in `<main>'
12:44:58 (See full trace by running task with --trace)

Foreigner is no longer present in this branch, replaced by the native FK support in Rails 4.2. I don't know if there are further issues.


Related issues

Related to Foreman - Feature #13244: Upgrade Ruby on Rails to 4.2Closed2016-01-15
Related to Katello - Refactor #14736: Fix test deprecation warnings from AR find method in Rails 4.2Closed2016-04-20

Associated revisions

Revision 925e5688 (diff)
Added by David Davis over 3 years ago

Refs #14156 - Backporting Rails 4.2 changes (#5958)

Revision 5e391125 (diff)
Added by David Davis over 3 years ago

Fixes #14156 - Upgrade to Rails 4.2 (#5954)

History

#1 Updated by Dominic Cleal over 3 years ago

#2 Updated by Eric Helms over 3 years ago

  • Assignee set to David Davis
  • Legacy Backlogs Release (now unused) set to 143

#3 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5954 added

#4 Updated by The Foreman Bot over 3 years ago

  • Pull request https://github.com/Katello/katello/pull/5958 added

#5 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by David Davis over 3 years ago

  • Related to Refactor #14736: Fix test deprecation warnings from AR find method in Rails 4.2 added

Also available in: Atom PDF