Project

General

Profile

Bug #14198

remote_addr validation is too strict for a regular expression

Added by Dominic Cleal about 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Settings
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

#6924 validates the remote_addr setting to permit only a list of pipe-separated IP addresses. It's actually a regular expression according to our docs (http://theforeman.org/manuals/1.10/index.html#3.5.2ConfigurationOptions):

remote_addr

If Foreman is running behind Passenger or a remote load balancer, the IP of this load balance should be set here. This is a regular expression, so it can support several load balancers, i.e: (10.0.0.1|127.0.0.1) Default: 127.0.0.1

Although the example is a simple regexp with two IPs and the or expression, regexes can be far more complex. It might be used to permit a whole subnet (e.g. ^10.0.0.\d+$).


Related issues

Related to Foreman - Bug #6924: UI should throw proper validation error while updating some params with any random value(like utf-8 or -ve values)Closed2014-08-05

Associated revisions

Revision 27def3d6 (diff)
Added by Ondřej Pražák about 6 years ago

Fixes #14198 - remote_addr validation accepts regex with digit matching

History

#1 Updated by Dominic Cleal about 6 years ago

  • Related to Bug #6924: UI should throw proper validation error while updating some params with any random value(like utf-8 or -ve values) added

#2 Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ondřej Pražák
  • Pull request https://github.com/theforeman/foreman/pull/3329 added

#3 Updated by Ondřej Pražák about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF