Failed pulp tasks are not resumable.
Partially introduced in https://github.com/Katello/katello/pull/5567
a user is no longer able to 'resume' a failed pulp task. The task never gets restarted in pulp. The task seems to resume in dynflow, but is never restarted in pulp.
Its not the easiest thing to actually reproduce without introducing an exception in pulp via a code change.
Fixes #14209 - allow for restarting of pulp tasks on resume
The root cause of this is that this commit:
made it so that resume_external_action no longer threw an exception. Due
to a recent change in dynflow it is needed to throw an exception in the case of
a non-network error. So this change returns the functionality of checking for
pulp task errors on polling, but overrides poll_external_task_with_rescue to not
treat pulp errors as poll errors.