Project

General

Profile

Refactor #14291

Remove app logins from every integration test

Added by Dominic Cleal about 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Each integration test currently runs the login_admin integration test helper which navigates to the index page, fills in the login form and submits it before running the main contents of the test. This is inefficient and adds two requests and some time to the execution of each test.

The login process should be removed from the test steps and tested once by itself, instead of on every integration test. The SSO mechanism in Foreman can be used to automate the login process instead.

Associated revisions

Revision 5c02935a (diff)
Added by Dominic Cleal about 6 years ago

fixes #14291 - replace integration test logins with SSO

Replace the loading and form-filling on the user login page with a
test-only SSO method, which automatically logs in the test user on
every request. This uses a cookie sent in the request to specify the
user.

History

#1 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3353 added

#2 Updated by Marek Hulán about 6 years ago

  • Legacy Backlogs Release (now unused) set to 136

#3 Updated by Dominic Cleal about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF