Project

General

Profile

Refactor #14319

Remove media_path template helper which is no longer used

Added by Marek Hulán about 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I haven't find any use of it among community-templates. I think it would be fair to mark as deprecated though. If this could get into 1.11 (as very small change) we'd get one cycle of deprecation warnings.


Related issues

Related to Foreman - Bug #9782: Using media_path in Templates does not resolve properlyClosed2015-03-16

Associated revisions

Revision 545444ec (diff)
Added by Marek Hulán about 4 years ago

Fixes #14319 - removes unused media_path template helper

History

#1 Updated by Marek Hulán about 4 years ago

  • Status changed from New to Assigned

So, I realized that media_path is actually unreachable when rendering the template. That's because when you call media_path, it uses rails route helpers and gives you '/media' as result. Therefore I don't see much benefit of adding deprecation warning there, someone could still use this helpers directly from plugin but since it's usecase is for templates rendering I think it's very unlikely. Also it could be easily reverted if needed. Thus I'll simply remove it.

#2 Updated by The Foreman Bot about 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3359 added

#3 Updated by Michael Moll about 4 years ago

  • Related to Bug #9782: Using media_path in Templates does not resolve properly added

#4 Updated by Marek Hulán about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal about 4 years ago

  • Legacy Backlogs Release (now unused) set to 136

Also available in: Atom PDF