Project

General

Profile

Actions

Refactor #14319

closed

Remove media_path template helper which is no longer used

Added by Marek Hulán almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

I haven't find any use of it among community-templates. I think it would be fair to mark as deprecated though. If this could get into 1.11 (as very small change) we'd get one cycle of deprecation warnings.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #9782: Using media_path in Templates does not resolve properlyClosed03/16/2015Actions
Actions #1

Updated by Marek Hulán almost 9 years ago

  • Status changed from New to Assigned

So, I realized that media_path is actually unreachable when rendering the template. That's because when you call media_path, it uses rails route helpers and gives you '/media' as result. Therefore I don't see much benefit of adding deprecation warning there, someone could still use this helpers directly from plugin but since it's usecase is for templates rendering I think it's very unlikely. Also it could be easily reverted if needed. Thus I'll simply remove it.

Actions #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3359 added
Actions #3

Updated by Anonymous almost 9 years ago

  • Related to Bug #9782: Using media_path in Templates does not resolve properly added
Actions #4

Updated by Marek Hulán almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal almost 9 years ago

  • Translation missing: en.field_release set to 136
Actions

Also available in: Atom PDF