Actions
Refactor #14319
closedRemove media_path template helper which is no longer used
Description
I haven't find any use of it among community-templates. I think it would be fair to mark as deprecated though. If this could get into 1.11 (as very small change) we'd get one cycle of deprecation warnings.
Updated by Marek Hulán almost 9 years ago
- Status changed from New to Assigned
So, I realized that media_path is actually unreachable when rendering the template. That's because when you call media_path, it uses rails route helpers and gives you '/media' as result. Therefore I don't see much benefit of adding deprecation warning there, someone could still use this helpers directly from plugin but since it's usecase is for templates rendering I think it's very unlikely. Also it could be easily reverted if needed. Thus I'll simply remove it.
Updated by The Foreman Bot almost 9 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3359 added
Updated by Anonymous almost 9 years ago
- Related to Bug #9782: Using media_path in Templates does not resolve properly added
Updated by Marek Hulán almost 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 545444ec079a421fc173e1f92a352c256c4c4b9a.
Updated by Dominic Cleal almost 9 years ago
- Translation missing: en.field_release set to 136
Actions