Refactor #14566: Replace show_console_action with a simple if statement - Foreman

Actions

Copy link

Refactor #14566

closed

Replace show_console_action with a simple if statement

Added by Tomer Brisker over 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomer Brisker

Category:

Web Interface

Target version:

1.12.0

Difficulty:

trivial

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/3418

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The show_console_action in the CR helper is simply checks a condition and displays the link if the condition is met.
This causes the link to be generated in any case so it can be passed into the function, instead of just checking the condition.
When fixing this, need to check if any CR plugin uses this helper.