Project

General

Profile

Actions

Refactor #14566

closed

Replace show_console_action with a simple if statement

Added by Tomer Brisker almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
trivial
Triaged:
Fixed in Releases:
Found in Releases:

Description

The show_console_action in the CR helper is simply checks a condition and displays the link if the condition is met.
This causes the link to be generated in any case so it can be passed into the function, instead of just checking the condition.
When fixing this, need to check if any CR plugin uses this helper.

Actions #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/3418 added
Actions #2

Updated by Anonymous almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal almost 8 years ago

  • translation missing: en.field_release set to 136
Actions

Also available in: Atom PDF