Project

General

Profile

Actions

Refactor #14699

closed

Katello needs foreman's os_selected method to submit all form data

Added by Partha Aji over 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Host creation
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Foreman's os_selected method. Last seen at -> https://github.com/theforeman/foreman/blob/develop/app/assets/javascripts/host_edit.js#L358
has code that looks like this
attrs = attribute_hash(['operatingsystem_id', 'organization_id', 'location_id']) limiting the number of attributes to the server for media selection to 4 parameters. This makes it very hard for Katello and Other foreman plugin apps to have control over that section of the medium even with facilities like Deface.
We need to make os_selected call actually send the full form as part of the hash, so that this can be used by the backend controllers.

We need os_selected to do something along the lines of

function os_selected(element){
  update_form(element);
  update_provisioning_image();
}

Related issues 2 (0 open2 closed)

Related to Katello - Bug #16063: Autoprovisioning fails with Katello plugin installedClosedLukas Zapletal08/11/2016Actions
Blocks Katello - Bug #19226: Katello needs to update os_selected method to submit all form dataClosedPartha Aji04/18/2016Actions
Actions #1

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release set to 114
Actions #2

Updated by Partha Aji over 7 years ago

  • Project changed from Katello to Foreman
Actions #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4444 added
Actions #4

Updated by Partha Aji over 7 years ago

  • Copied to Bug #19226: Katello needs to update os_selected method to submit all form data added
Actions #5

Updated by Partha Aji over 7 years ago

  • Copied to deleted (Bug #19226: Katello needs to update os_selected method to submit all form data)
Actions #6

Updated by Partha Aji over 7 years ago

  • Blocks Bug #19226: Katello needs to update os_selected method to submit all form data added
Actions #7

Updated by Lukas Zapletal over 7 years ago

  • Related to Bug #16063: Autoprovisioning fails with Katello plugin installed added
Actions #8

Updated by Dominic Cleal over 7 years ago

  • Translation missing: en.field_release deleted (114)
Actions #9

Updated by Daniel Lobato Garcia over 7 years ago

  • Translation missing: en.field_release set to 248

Setting release to 1.15.1 as it's 3.4.1 on the PR that requires this change in Katello

Actions #10

Updated by Partha Aji over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #11

Updated by Dominic Cleal over 7 years ago

  • Tracker changed from Bug to Refactor
  • Category set to Host creation

Release should probably be re-evaluated for a refactoring/new API.

Actions

Also available in: Atom PDF