Project

General

Profile

Bug #14741

Host templates tab fails with mark_translated: no implicit conversion of TemplateKind into String

Added by Dominic Cleal about 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When viewing a host and mark_translated is enabled in settings.yaml, the templates tab on the host#show page fails to render with:

2016-04-21T09:25:27 [app] [W] Failed to fetch templates information
 | ActionView::Template::Error: no implicit conversion of TemplateKind into String
 | /home/dcleal/code/foreman/foreman/lib/foreman/gettext/debug.rb:14:in `+'
 | /home/dcleal/code/foreman/foreman/lib/foreman/gettext/debug.rb:14:in `_'
 | /home/dcleal/code/foreman/foreman/app/views/hosts/_templates.html.erb:11:in `block in _app_views_hosts__templates_html_erb___4147745246099588976_70066143274580'
 | /home/dcleal/code/foreman/foreman/app/views/hosts/_templates.html.erb:9:in `each'
 | /home/dcleal/code/foreman/foreman/app/views/hosts/_templates.html.erb:9:in `_app_views_hosts__templates_html_erb___4147745246099588976_70066143274580'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/template.rb:145:in `block in render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activesupport-4.2.6/lib/active_support/notifications.rb:166:in `instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/template.rb:333:in `instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/template.rb:143:in `render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/partial_renderer.rb:339:in `render_partial'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/partial_renderer.rb:310:in `block in render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/abstract_renderer.rb:39:in `block in instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activesupport-4.2.6/lib/active_support/notifications.rb:164:in `block in instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activesupport-4.2.6/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activesupport-4.2.6/lib/active_support/notifications.rb:164:in `instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/abstract_renderer.rb:39:in `instrument'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/partial_renderer.rb:309:in `render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/renderer.rb:51:in `render_partial'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/renderer/renderer.rb:25:in `render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/rendering.rb:100:in `_render_template'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/streaming.rb:217:in `_render_template'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionview-4.2.6/lib/action_view/rendering.rb:83:in `render_to_body'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/rendering.rb:32:in `render_to_body'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/renderers.rb:37:in `render_to_body'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/abstract_controller/rendering.rb:25:in `render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/rendering.rb:16:in `render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activesupport-4.2.6/lib/active_support/core_ext/benchmark.rb:12:in `block in ms'
 | /home/dcleal/.rvm/rubies/ruby-2.0.0-p353/lib/ruby/2.0.0/benchmark.rb:296:in `realtime'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activesupport-4.2.6/lib/active_support/core_ext/benchmark.rb:12:in `ms'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/instrumentation.rb:44:in `block in render'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/activerecord-4.2.6/lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime'
 | /home/dcleal/.rvm/gems/ruby-2.0.0-p353@foreman/gems/actionpack-4.2.6/lib/action_controller/metal/instrumentation.rb:43:in `render'
 | /home/dcleal/code/foreman/foreman/app/controllers/hosts_controller.rb:276:in `templates'

Since #14395.


Related issues

Related to Foreman - Bug #14395: Hosts > Operating Systems > [OS] > Templates tab: "provision" field label is lowercase, should be "Provision"Closed2016-03-30

Associated revisions

Revision c89a8d23 (diff)
Added by Dominic Cleal about 6 years ago

fixes #14741 - translate template kind string, not object

Also convert translation keys to strings in debug mode to prevent
concatenation errors.

History

#1 Updated by Dominic Cleal about 6 years ago

  • Related to Bug #14395: Hosts > Operating Systems > [OS] > Templates tab: "provision" field label is lowercase, should be "Provision" added

#2 Updated by Dominic Cleal about 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal

#3 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3446 added

#4 Updated by Dominic Cleal about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF