Project

General

Custom queries

Profile

Actions

Bug #14797

closed

Medium validation wrong with Katello and foreman_bootdisk

Added by Timo Goebel about 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Both foreman_bootdisk and Katello overwrite validate_media? in the Host Model and the wrong order is applied.

What you can try as a workaround is the following:
Remove or comment

alias_method_chain :validate_media?, :bootdisk
from app/models/concerns/foreman_bootdisk/host_ext.rb

See:
https://github.com/Katello/katello/blob/b92a833e38fa3b39deff26839b219c0b7da53bbb/app/models/katello/concerns/host_managed_extensions.rb#L34-L36
https://github.com/theforeman/foreman_bootdisk/blob/master/app/models/concerns/foreman_bootdisk/host_ext.rb#L36-L38


Related issues 5 (1 open4 closed)

Related to Foreman Remote Execution - Refactor #21205: Replace alias_method_chain with Module prepend ClosedIvan Necas10/05/2017Actions
Related to Katello - Bug #21243: Rails 5 - Replace alias_method_chain with Module prependClosedJustin Sherrill10/09/2017Actions
Related to Foreman - Refactor #20957: Replace alias_method_chain with Module prepend Closed09/16/2017Actions
Related to Foreman - Refactor #22219: Refactor validate_media? to be hookableNew01/10/2018Actions
Related to Foreman - Refactor #25680: Allow plugins to override validate_media?ClosedLukas ZapletalActions
Actions #2

Updated by Lukas Zapletal over 7 years ago

Both bootdisk and katello are now on "prepend" FYI. I haven't tested if this helped tho.

https://github.com/Katello/katello/blob/master/app/models/katello/concerns/host_managed_extensions.rb#L9-L11

Actions #6

Updated by Lukas Zapletal over 7 years ago

  • Status changed from New to Need more information

I believe this was fixed both in 10.0.1 and 11.x series of Bootdisk now.

Actions #9

Updated by Lukas Zapletal over 6 years ago

  • Status changed from Ready For Testing to Need more information
  • Triaged changed from No to Yes

Timo, I believe we can close this one.

Actions #10

Updated by Timo Goebel over 6 years ago

Lukas Zapletal wrote:

Timo, I believe we can close this one.

I think this still applies. Katello and Foreman Bootdisk still override the same method.

Actions #14

Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF